git.sesse.net Git - kdenlive/log

projectlist.cpp: check for null before referencing

Fixes Coverity CID 709302: Dereference before null check (REVERSE_INULL)
Dereferencing pointer "this->m_render". [show details]
736        int width = (int)(height  * m_render->dar());
...
Dereferencing "this->m_render" before a null check.
749            if (m_render == NULL) {
750                kDebug() << "*********  ERROR, NULL RENDR";
751                return;

projectlistview.cpp: check for null pointer

Fixes Coverity CID 709291: Explicit null dereferenced (FORWARD_NULL)
Passing null variable "item" to function "FolderProjectItem::groupName() const", which dereferences it. [show details]
272 props.insert("groupname", item->groupName());
...
Assigning: "item" = 0.
276 } else item = NULL;

projectsettings.cpp: return if open() fails

Fixes Coverity CID 709281: Unchecked return value (CHECKED_RETURN)
Calling function "QFile::open(QFlags<QIODevice::OpenModeFlag>)" without checking return value (as is done elsewhere 45 out of 47 times).
No check of the return value of "xmlf.open(QIODevice::OpenMode(_ZN9QIODevice9WriteOnlyE))".
552 xmlf.open(QIODevice::WriteOnly);

audioEnvelope.cpp: check for division by zero

Fixes Coverity CID 709287: Division or modulo by zero (DIVIDE_BY_ZERO)
Call to "this->loadEnvelope()" set "this->m_envelopeMax" to 0.
182 loadEnvelope();
...
Division by expression "this->m_envelopeMax" which may be zero has undefined behavior
189 fy = m_envelope[x]/double(m_envelopeMax) * img.height();

kthumb.cpp: check for division by zero

CID 709285: Division or modulo by zero (DIVIDE_BY_ZERO)
Division by expression "STEPS" which may be zero has undefined behavior
250 avg=avg/STEPS;

kis_cubic_curve.cpp: initialize variables

Fixes Coverity CID 709308: Uninitialized scalar field (UNINIT_CTOR)

Non-static class member ""m_begin"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""m_end"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""m_intervals"" is not initialized in this constructor nor in any functions that it calls.

meltjob.cpp: initialize addClipToProject

Fixes Coverity CID 709312: Uninitialized scalar field (UNINIT_CTOR)
Non-static class member ""addClipToProject"" is not initialized in this constructor nor in any functions that it calls.

audioCorrelationInfo.cpp: check for division by zero

Fixes Coverity CID 709286: Division or modulo by zero (DIVIDE_BY_ZERO)
Assigning: "maxVal" = "this->max()".
On this path, function call "this->max()" has return value of 0
78 int64_t maxVal = max();
...
Division by expression "maxVal" which may be zero has undefined behavior
86 val = m_correlationVector[x]/double(maxVal)*img.height();

histogramgenerator.cpp: check for division by zero

Fixes Coverity CID 709284: Division or modulo by zero (DIVIDE_BY_ZERO)
Division by expression "byteCount >> 7" which may be zero has undefined behavior
87 const float scaling = (float)partH/(byteCount >> 7);

effectstackview2.cpp: check for null

Fixes Coverity CID 709289: Explicit null dereferenced (FORWARD_NULL)
Assigning: "effectToMove" = 0.
790 CollapsibleEffect *effectToMove = NULL;
...
Passing null variable "effectToMove" to function "CollapsibleGroup::addGroupEffect(CollapsibleEffect *)", which dereferences it. [show details]
805 group->addGroupEffect(effectToMove);

effectstackview2.cpp: check for null pointer

Fixes Coverity CID 709290: Dereference after null check (FORWARD_NULL)
Comparing "this->m_clipref" to null implies that "this->m_clipref" might be null.
717 else if (m_clipref) {
...
Passing null variable "this->m_clipref" to function "AbstractClipItem::info() const", which dereferences it. [show details]
733 info = m_clipref->info();

dvdwizardvob.cpp: check return value

Fixes Coverity CID 709275: Unchecked return value (CHECKED_RETURN)
Calling function "QDomDocument::setContent(QIODevice *, QString *, int *, int *)" without checking return value (as is done elsewhere 6 out of 7 times).
No check of the return value of "doc.setContent(&file, NULL, NULL, NULL)".
134 doc.setContent(&file);