6 years agoCache the FFT support texture.
Steinar H. Gunderson [Sat, 22 Mar 2014 16:18:12 +0000 (17:18 +0100)]
Cache the FFT support texture.

Regenerating it every time is a waste of CPU, and also of GL
state changes.

6 years agoUse a smaller support texture for the FFT.
Steinar H. Gunderson [Sat, 22 Mar 2014 16:09:36 +0000 (17:09 +0100)]
Use a smaller support texture for the FFT.

Many of the rows in the support texture are exactly the same,
so don't store the duplicates; gives a small performance boost.
In a sense, this is exactly the same property that GPUwave uses
with drawing multiple quads at the lower level.

6 years agoFix a tiny leak (that would cause an assertion failure on exit).
Steinar H. Gunderson [Sat, 22 Mar 2014 15:18:12 +0000 (16:18 +0100)]
Fix a tiny leak (that would cause an assertion failure on exit).

6 years agoStop the FFTPassEffect Repeat test after FFT size 128.
Steinar H. Gunderson [Sat, 22 Mar 2014 15:12:47 +0000 (16:12 +0100)]
Stop the FFTPassEffect Repeat test after FFT size 128.

The reason is that the 256 test uses texture sizes of 256*31=7936,
and above ~3900, some cards (at least both my Intel and NVidia card)
start having accuracy issues on some sizes. The test happens not to
die on this for semi-obscure reasons, but that's mostly by accident,
and in any case, requiring 8k textures for a unit test might be
a bit on the upper side.

6 years agoFactor out the actual phase execution into a function.
Steinar H. Gunderson [Sat, 22 Mar 2014 14:49:09 +0000 (15:49 +0100)]
Factor out the actual phase execution into a function.

6 years agoFactor out RTT sampler setting in its own function.
Steinar H. Gunderson [Sat, 22 Mar 2014 14:34:07 +0000 (15:34 +0100)]
Factor out RTT sampler setting in its own function.

6 years agoRedo FBO association yet again, this time per-texture.
Steinar H. Gunderson [Sat, 22 Mar 2014 13:54:43 +0000 (14:54 +0100)]
Redo FBO association yet again, this time per-texture.

According to,
you want an FBO per-texture, not just format. And indeed, I can measure a very slight
performance improvement on both NVidia and ATI for this.

6 years agoHave separate FBOs per resolution and format.
Steinar H. Gunderson [Fri, 21 Mar 2014 23:29:21 +0000 (00:29 +0100)]
Have separate FBOs per resolution and format.

Seemingly this _also_ costs on NVidia; the demo app is down 0.9 ms/frame or so.
This rapidly started approaching complexity worthy of the ResourcePool,
so I moved the functionality in there even though it's not context-shareable.

6 years agoRemove obsolete comment.
Steinar H. Gunderson [Fri, 21 Mar 2014 22:42:08 +0000 (23:42 +0100)]
Remove obsolete comment.

6 years agoFix a buffer overflow in MixEffectTest.
Steinar H. Gunderson [Thu, 20 Mar 2014 22:48:46 +0000 (23:48 +0100)]
Fix a buffer overflow in MixEffectTest.

6 years agoConvert another glReadPixels() to RGBA.
Steinar H. Gunderson [Thu, 20 Mar 2014 22:15:23 +0000 (23:15 +0100)]
Convert another glReadPixels() to RGBA.

6 years agoProperly ignore the sign bit when comparing NaNs.
Steinar H. Gunderson [Thu, 20 Mar 2014 21:59:59 +0000 (22:59 +0100)]
Properly ignore the sign bit when comparing NaNs.

Fixes fp16_test test failure on Clang.

6 years agoDitch BGRA use in OverlayEffectTest.
Steinar H. Gunderson [Thu, 20 Mar 2014 21:48:32 +0000 (22:48 +0100)]
Ditch BGRA use in OverlayEffectTest.

6 years agoFix non-float framebuffers in EffectChainTester.
Steinar H. Gunderson [Thu, 20 Mar 2014 20:46:32 +0000 (21:46 +0100)]
Fix non-float framebuffers in EffectChainTester.

Again, GLES fix.

6 years agoRemove unused private members from FFTConvolutionEffect.
Steinar H. Gunderson [Thu, 20 Mar 2014 20:27:37 +0000 (21:27 +0100)]
Remove unused private members from FFTConvolutionEffect.

6 years agoUse the right internal format for FORMAT_R non-float textures.
Steinar H. Gunderson [Thu, 20 Mar 2014 20:15:13 +0000 (21:15 +0100)]
Use the right internal format for FORMAT_R non-float textures.

6 years agoAdd a few check_error() calls.
Steinar H. Gunderson [Thu, 20 Mar 2014 20:14:22 +0000 (21:14 +0100)]
Add a few check_error() calls.

6 years agoDon't use GL_RGBA32F/GL_RGBA16F with GL_UNSIGNED_BYTE.
Steinar H. Gunderson [Thu, 20 Mar 2014 20:12:31 +0000 (21:12 +0100)]

GLES doesn't like this, even with NULL data. Replace with GL_FLOAT.

6 years agoAdd a temporary variable to reduce the amount of tedious typing.
Steinar H. Gunderson [Wed, 19 Mar 2014 20:06:17 +0000 (21:06 +0100)]
Add a temporary variable to reduce the amount of tedious typing.

6 years agoFix a typo.
Steinar H. Gunderson [Wed, 19 Mar 2014 23:42:02 +0000 (00:42 +0100)]
Fix a typo.

6 years agoReduce the amount of arithmetic in the BlurEffect shader a bit.
Steinar H. Gunderson [Tue, 18 Mar 2014 23:12:34 +0000 (00:12 +0100)]
Reduce the amount of arithmetic in the BlurEffect shader a bit.

We did additions and subtractions with zero, which is sort of a waste
on scalar architectures. Helps ever so slightly on the demo app on my NVidia
card (3–4%).

6 years agoMake VAOs persistent.
Steinar H. Gunderson [Tue, 18 Mar 2014 22:18:56 +0000 (23:18 +0100)]
Make VAOs persistent.

Seemingly helps ~0.5 ms/frame (which is quite significant for small
resolutions) on the demo applications on my NVidia card.

6 years agoKeep FBOs around in EffectChain again.
Steinar H. Gunderson [Tue, 18 Mar 2014 21:16:36 +0000 (22:16 +0100)]
Keep FBOs around in EffectChain again.

Seemingly creating and deleting them is crazy expensive on NVidia
(~3 ms for a create/delete pair), so 6dea8d2 caused a performance
regression at high frame rates. Now we instead keep one around per
context (they cannot be shared), which brings us basically back
to where we were performance-wise.

Reported by Christophe Thommeret.

6 years agoMake Phase take other Phases as inputs, not Nodes.
Steinar H. Gunderson [Mon, 17 Mar 2014 23:57:53 +0000 (00:57 +0100)]
Make Phase take other Phases as inputs, not Nodes.

This was a refactoring I wanted to do for a while, but actually finding
the right structure was a bit tricky. In the process, the entire phase
generation logic was rewritten, but the separation between compilation
and Phase construction is much cleaner now, and the logic in general
is easier to follow with more use of explicit recursion.

I'm still not 100% happy about what might be overuse of output_node;
we still need to link Phase and Node (the link just goes the other way
now), but I'm not sure we need to use it in all the cases we currently do.

6 years agoDocument the FFTW3 requirement.
Steinar H. Gunderson [Mon, 17 Mar 2014 00:47:30 +0000 (01:47 +0100)]
Document the FFTW3 requirement.

6 years agoMovit can hardly be said to be in alpha stage anymore.
Steinar H. Gunderson [Mon, 17 Mar 2014 00:45:10 +0000 (01:45 +0100)]
Movit can hardly be said to be in alpha stage anymore.

6 years agoRemove obsolete file.
Steinar H. Gunderson [Mon, 17 Mar 2014 00:26:13 +0000 (01:26 +0100)]
Remove obsolete file.

This was part of my original scribblings, and is no longer needed.

6 years agoRelease Movit 1.0.3. 1.0.3
Steinar H. Gunderson [Sun, 16 Mar 2014 22:29:07 +0000 (23:29 +0100)]
Release Movit 1.0.3.

6 years agoMove private libs into Libs.private in the pkg-config file.
Steinar H. Gunderson [Sun, 16 Mar 2014 22:26:04 +0000 (23:26 +0100)]
Move private libs into Libs.private in the pkg-config file.

6 years agoAdd FFTW3 libs and flags to the pkg-config file.
Steinar H. Gunderson [Sun, 16 Mar 2014 22:22:43 +0000 (23:22 +0100)]
Add FFTW3 libs and flags to the pkg-config file.

6 years agoTake LDFLAGS properly from configure, and distinguish better between LDFLAGS and...
Steinar H. Gunderson [Sun, 16 Mar 2014 22:08:17 +0000 (23:08 +0100)]
Take LDFLAGS properly from configure, and distinguish better between LDFLAGS and LDLIBS.

6 years agoDo not link libmovit against SDL; only the unit tests need that.
Steinar H. Gunderson [Sun, 16 Mar 2014 22:01:29 +0000 (23:01 +0100)]
Do not link libmovit against SDL; only the unit tests need that.

6 years agoRelease Movit 1.0.2. 1.0.2
Steinar H. Gunderson [Sun, 16 Mar 2014 21:35:02 +0000 (22:35 +0100)]
Release Movit 1.0.2.

6 years agoMake $(libdir) on make install, in case it does not exist.
Steinar H. Gunderson [Sun, 16 Mar 2014 21:40:24 +0000 (22:40 +0100)]
Make $(libdir) on make install, in case it does not exist.

6 years agoMake make install honor DESTDIR.
Steinar H. Gunderson [Sun, 16 Mar 2014 21:33:53 +0000 (22:33 +0100)]
Make make install honor DESTDIR.

6 years agoRelease Movit 1.0.1. 1.0.1
Steinar H. Gunderson [Sun, 16 Mar 2014 21:19:24 +0000 (22:19 +0100)]
Release Movit 1.0.1.

6 years agoFix a C++11 incompatibility.
Steinar H. Gunderson [Sun, 16 Mar 2014 21:16:07 +0000 (22:16 +0100)]
Fix a C++11 incompatibility.

6 years agoRevert "Stop using -rpath when linking libmovit."
Steinar H. Gunderson [Sun, 16 Mar 2014 21:13:45 +0000 (22:13 +0100)]
Revert "Stop using -rpath when linking libmovit."

Actually, this is seemingly needed to build shared libraries at all. Doh.

This reverts commit 05466cbaae2befac3d3ab8bbba614bc08646d3f2.

6 years agoRelease Movit 1.0. 1.0
Steinar H. Gunderson [Sun, 16 Mar 2014 20:39:37 +0000 (21:39 +0100)]
Release Movit 1.0.

6 years agoMake a 'make dist' target.
Steinar H. Gunderson [Sun, 16 Mar 2014 20:08:28 +0000 (21:08 +0100)]
Make a 'make dist' target.

6 years agoAdd the two missing FFT shaders to MISSING_SHADERS.
Steinar H. Gunderson [Sun, 16 Mar 2014 19:19:36 +0000 (20:19 +0100)]
Add the two missing FFT shaders to MISSING_SHADERS.

6 years agoStop using -rpath when linking libmovit.
Steinar H. Gunderson [Sun, 16 Mar 2014 19:12:11 +0000 (20:12 +0100)]
Stop using -rpath when linking libmovit.

This was from pre-libtool days, and makes no sense now. Plus it seems to have
no actual effect.

6 years agoStart doing symbol versioning.
Steinar H. Gunderson [Sun, 16 Mar 2014 19:11:38 +0000 (20:11 +0100)]
Start doing symbol versioning.

As we prepare for 1.0, we want to make sure we have a proper soname.
See the comment for slightly more details.

6 years agoAdd an FFT convolution effect.
Steinar H. Gunderson [Sun, 16 Mar 2014 18:25:53 +0000 (19:25 +0100)]
Add an FFT convolution effect.

A lot of the later commits have been leading up to this, and I finally
got to the point where all the unit tests check out, everything seems
to work (modulo maybe some overflow issues) and we have a model that
matches what people actually expects from convolutions.

Note that this adds a dependency on FFTW3; we could probably have added
our own routines for such small needs, but like with Eigen, calling out to a
library is fine as long as it's of good quality (which FFTW certainly is) and
is widely available.

6 years agoMake SliceEffect slice from the top, not the bottom.
Steinar H. Gunderson [Sat, 15 Mar 2014 20:53:10 +0000 (21:53 +0100)]
Make SliceEffect slice from the top, not the bottom.

This is more consistent with the rest of Movit, and makes the rest
of the FFT implementation easier.

6 years agoRevert "Support pad/crop from bottom, not just from the top."
Steinar H. Gunderson [Sat, 15 Mar 2014 20:51:32 +0000 (21:51 +0100)]
Revert "Support pad/crop from bottom, not just from the top."

This turned out not to be so useful after all, as we'd like a more
consistent top-left coordinate system, and changes to do that will
obsolete this patch.

This reverts commit e92a5ffa19eb67b4db5af1db8559630139073668.

6 years agoIn the README, document that we have luma mix.
Steinar H. Gunderson [Sat, 15 Mar 2014 19:46:07 +0000 (20:46 +0100)]
In the README, document that we have luma mix.

6 years agoSupport pad/crop from bottom, not just from the top.
Steinar H. Gunderson [Sat, 15 Mar 2014 18:13:38 +0000 (19:13 +0100)]
Support pad/crop from bottom, not just from the top.

This is convenient for the FFTs that are coming.

6 years agoFix a bug where repeated vertical FFTs would reverse the output.
Steinar H. Gunderson [Sat, 15 Mar 2014 02:04:31 +0000 (03:04 +0100)]
Fix a bug where repeated vertical FFTs would reverse the output.

Unfortunately, the tests didn't catch this, as the Repeat test used
an even number of passes (being of size 64), which reversed things
back into place. It now tries a wider range of sizes to make sure
everything is okay.

6 years agoProperly install texture1d.frag, which is needed during init.
Steinar H. Gunderson [Thu, 13 Mar 2014 20:44:15 +0000 (21:44 +0100)]
Properly install texture1d.frag, which is needed during init.

6 years agoProperly install fp16.h.
Steinar H. Gunderson [Thu, 13 Mar 2014 20:41:35 +0000 (21:41 +0100)]
Properly install fp16.h.

6 years agoMore tweaks to the .ld generation.
Steinar H. Gunderson [Wed, 12 Mar 2014 21:48:07 +0000 (22:48 +0100)]
More tweaks to the .ld generation.

6 years agoAdd more unit tests for fp16.
Steinar H. Gunderson [Wed, 12 Mar 2014 00:24:39 +0000 (01:24 +0100)]
Add more unit tests for fp16.

This tests a few edge cases that are not adequately covered by the
random fp32 tests; in particular, the round-to-even logic had
no test coverage, which is bad.

6 years agoMake the COVERAGE variable into an --enable-coverage configure flag.
Steinar H. Gunderson [Wed, 12 Mar 2014 00:24:03 +0000 (01:24 +0100)]
Make the COVERAGE variable into an --enable-coverage configure flag.

This makes a lot more sense, since it controls compilation options.

6 years ago.gitignore lots of libtool stuff.
Steinar H. Gunderson [Tue, 11 Mar 2014 23:55:05 +0000 (00:55 +0100)]
.gitignore lots of libtool stuff.

6 years ago.gitignore more unit tests.
Steinar H. Gunderson [Tue, 11 Mar 2014 23:53:33 +0000 (00:53 +0100)]
.gitignore more unit tests.

6 years agoIgnore .ld files.
Steinar H. Gunderson [Tue, 11 Mar 2014 23:51:26 +0000 (00:51 +0100)]
Ignore .ld files.

6 years agoFix some formatting messups.
Steinar H. Gunderson [Tue, 11 Mar 2014 23:09:16 +0000 (00:09 +0100)]
Fix some formatting messups.

6 years agoAdd a simple luma wipe transition.
Steinar H. Gunderson [Tue, 11 Mar 2014 23:05:28 +0000 (00:05 +0100)]
Add a simple luma wipe transition.

6 years agoSupport GL_R and 16-bit fixed-point textures in FlatInput.
Steinar H. Gunderson [Tue, 11 Mar 2014 20:13:34 +0000 (21:13 +0100)]
Support GL_R and 16-bit fixed-point textures in FlatInput.

The motivating need is that we want GL_R16 textures soon.

6 years agoFix dependencies for .lo files.
Steinar H. Gunderson [Tue, 11 Mar 2014 00:38:05 +0000 (01:38 +0100)]
Fix dependencies for .lo files.

Dependencies were unfortunately de-facto broken after introduction of libtool,
causing much head scratching. Now fixed.

6 years agoAdd an effect for complex multiplication.
Steinar H. Gunderson [Mon, 10 Mar 2014 23:33:58 +0000 (00:33 +0100)]
Add an effect for complex multiplication.

This is another building block to make the FFTs useful.

6 years agoFormalize the notion of messing with sampler state.
Steinar H. Gunderson [Mon, 10 Mar 2014 22:59:28 +0000 (23:59 +0100)]
Formalize the notion of messing with sampler state.

This kills a lot of the assumptions that have been going around,
and should allow us to deal much better with the situation when
we have two or more inputs to an effect (where you basically can't
predict the sampler number used reliably); there's still an edge
case that's documented with a TODO, but this is generally much better.

6 years agoHandle texture non-bounce a bit better.
Steinar H. Gunderson [Mon, 10 Mar 2014 21:09:18 +0000 (22:09 +0100)]
Handle texture non-bounce a bit better.

This allows us to ignore the texture bounce flag when reading from a
FlatInput, and also handles better the case where an YCbCrInput is read
from multiple times (it's now bounced, which should be better for speed,
I think).

The main motivation, however, is to be able to control sampler state
a bit less hackish in the future.

6 years agoAdd support for fp16 and RG textures to FlatInput.
Steinar H. Gunderson [Sun, 9 Mar 2014 22:31:47 +0000 (23:31 +0100)]
Add support for fp16 and RG textures to FlatInput.

6 years agoIgnore libtool files in .gitignore.
Steinar H. Gunderson [Sun, 9 Mar 2014 20:58:41 +0000 (21:58 +0100)]
Ignore libtool files in .gitignore.

6 years agoAdd an effect to do re-slicing of the image, for overlap/discard.
Steinar H. Gunderson [Sun, 9 Mar 2014 20:55:39 +0000 (21:55 +0100)]
Add an effect to do re-slicing of the image, for overlap/discard.

This is another step on the way to making FFT convolutions useful.

6 years agoAdd utility functions for EffectChain to add inputs of different size from the output.
Steinar H. Gunderson [Sun, 9 Mar 2014 20:54:51 +0000 (21:54 +0100)]
Add utility functions for EffectChain to add inputs of different size from the output.

6 years agoDo our own fp16 conversion in ResampleEffect.
Steinar H. Gunderson [Sun, 9 Mar 2014 17:22:18 +0000 (18:22 +0100)]
Do our own fp16 conversion in ResampleEffect.

This not only fixes issues with poor downconversion on ATI, but also
allows us to normalize while being aware of fp16 roundoff issues.
Seems to about cut the error in half in the HeavyResampleGetsSumRight
test, which as far as I can see would take us up to 10-bit accuracy.

6 years agoStore all twiddle factors as fp16.
Steinar H. Gunderson [Sun, 9 Mar 2014 16:41:03 +0000 (17:41 +0100)]
Store all twiddle factors as fp16.

Seemingly this isn't such a big deal after all, especially now that
we have proper fp16 roundoff also on ATI.

6 years agoAdd a utility library for downconverting to fp16.
Steinar H. Gunderson [Sun, 9 Mar 2014 16:24:00 +0000 (17:24 +0100)]
Add a utility library for downconverting to fp16.

ATI's drivers don't do this properly by themselves, so we want to
do it on our side. Adapted from some code I wrote a few years ago.

6 years agoFix the widget display in the demo app.
Steinar H. Gunderson [Sun, 9 Mar 2014 11:36:00 +0000 (12:36 +0100)]
Fix the widget display in the demo app.

The demo app forgot to set a projection matrix, and when Movit itself
stopped setting one, the widget display broke.

6 years agoFix the roundoff test.
Steinar H. Gunderson [Sun, 9 Mar 2014 11:29:47 +0000 (12:29 +0100)]
Fix the roundoff test.

The wrong texture coordinates snuck in here when changing from fixed function.

6 years agoStop using 1D textures.
Steinar H. Gunderson [Sun, 9 Mar 2014 00:42:27 +0000 (01:42 +0100)]
Stop using 1D textures.

1D textures were never part of GLES, so use 2D textures with Nx1 instead.
Supposedly they are just as fast (although it feels a bit less elegant).

6 years agoRemove GL_LUMINANCE in more places.
Steinar H. Gunderson [Sat, 8 Mar 2014 23:41:38 +0000 (00:41 +0100)]
Remove GL_LUMINANCE in more places.

Causes problems with GL 3.2+ core contexts. Found by testing on ATI.

6 years agoUse the GL_RED texture format instead of GL_LUMINANCE.
Steinar H. Gunderson [Sat, 8 Mar 2014 21:13:59 +0000 (22:13 +0100)]
Use the GL_RED texture format instead of GL_LUMINANCE.

Seemingly GL_LUMINANCE is also deprecated; this actually decreases
support for GLES2 somewhat, but we need GLES3 anyway, so the net
loss shouldn't be too bad.

6 years agoUse triangle strips instead of quads.
Steinar H. Gunderson [Sat, 8 Mar 2014 20:44:43 +0000 (21:44 +0100)]
Use triangle strips instead of quads.

GL_QUADS is deprecated, seemingly, so rearrange things a bit so that
they become small triangle strips instead.

6 years agoUse VAOs to bind the VBOs.
Steinar H. Gunderson [Sat, 8 Mar 2014 20:35:29 +0000 (21:35 +0100)]
Use VAOs to bind the VBOs.

Needed for OpenGL 3.2+ core context support. Also refactor a bit,
since the amount of boilerplate was getting over the top.

6 years agoMake the initializing functions also drop fixed function usage.
Steinar H. Gunderson [Sat, 8 Mar 2014 17:37:25 +0000 (18:37 +0100)]
Make the initializing functions also drop fixed function usage.

6 years agoUse GLSL 1.30-style attributes for the main shader.
Steinar H. Gunderson [Sat, 8 Mar 2014 17:33:17 +0000 (18:33 +0100)]
Use GLSL 1.30-style attributes for the main shader.

This is in preparation for removing fixed-function use altogether,
for OpenGL 3.2+ core context support.

6 years agoCheck GLSL program link status, for better error reporting.
Steinar H. Gunderson [Sat, 8 Mar 2014 16:18:35 +0000 (17:18 +0100)]
Check GLSL program link status, for better error reporting.

6 years agoUse abort() on check_error() failure.
Steinar H. Gunderson [Sat, 8 Mar 2014 20:57:04 +0000 (21:57 +0100)]
Use abort() on check_error() failure.

This makes it much easier to trace them down in a debugger.

6 years agoFix a typo.
Steinar H. Gunderson [Wed, 12 Feb 2014 01:15:25 +0000 (02:15 +0100)]
Fix a typo.

6 years agoMove everything into “namespace movit”.
Steinar H. Gunderson [Wed, 12 Feb 2014 01:04:19 +0000 (02:04 +0100)]
Move everything into “namespace movit”.

This is a pretty hard API break, but it's probably the last big API
break before 1.0, and some of the names (e.g. Effect, Input ResourcePool)
are really so generic that they should not be allowed to pollute the global

6 years agoMake init_movit() return a true/false error value.
Steinar H. Gunderson [Wed, 12 Feb 2014 00:44:42 +0000 (01:44 +0100)]
Make init_movit() return a true/false error value.

This allows clients to programmatically enable/disable Movit usage
as needed on very old platforms.

6 years agoMake a pow() call unambiguous.
Steinar H. Gunderson [Mon, 27 Jan 2014 22:04:44 +0000 (23:04 +0100)]
Make a pow() call unambiguous.

6 years agoRemove the finalize() member function from Input.
Steinar H. Gunderson [Sun, 26 Jan 2014 23:44:44 +0000 (00:44 +0100)]
Remove the finalize() member function from Input.

It is no longer needed now that the texture is not created once,
but rather fetched on-demand from the ResourcePool.

6 years agoSend shader compile log to stderr instead of stdout.
Steinar H. Gunderson [Sun, 26 Jan 2014 23:04:36 +0000 (00:04 +0100)]
Send shader compile log to stderr instead of stdout.

Reported by Dan Dennedy.

6 years agoExplicitly declare use of round() as an #extension.
Steinar H. Gunderson [Sun, 26 Jan 2014 23:03:36 +0000 (00:03 +0100)]
Explicitly declare use of round() as an #extension.

round() is not part of GLSL 1.10, so we need to check explicitly for it
before we can use it.

Reported by Dan Dennedy.

6 years agoIn EffectChainTest, do not re-call init_movit()
Steinar H. Gunderson [Sun, 26 Jan 2014 01:44:17 +0000 (02:44 +0100)]
In EffectChainTest, do not re-call init_movit()

Seemingly this causes problems on ATI, for unknown reasons.
In any case, just flipping the debug level is much easier.

6 years agoMake the ResampleEffect accuracy test stricter.
Steinar H. Gunderson [Sat, 25 Jan 2014 18:43:29 +0000 (19:43 +0100)]
Make the ResampleEffect accuracy test stricter.

First, make sure we test one individual pass, and that we test it in
fp32. Second, set a limit that's actually grounded in something real,
not just a pretty power of 10.

6 years agoNormalize the resample weight after bilinear combining.
Steinar H. Gunderson [Sat, 25 Jan 2014 18:41:40 +0000 (19:41 +0100)]
Normalize the resample weight after bilinear combining.

We introduce a small bit of error in the combining (due to having to
compensate for lack of subpixel sampling precision), so normalize
after it rather than before it. Also, do a second normalization pass,
which seemingly helps sometimes (probably due to inaccuracies in the
float sum).

This seems to kill about half the precision loss on Intel, at least.

6 years agoDon't dither alpha.
Steinar H. Gunderson [Sat, 25 Jan 2014 12:57:41 +0000 (13:57 +0100)]
Don't dither alpha.

For alpha, correct rounding is more important to us than overall
spectral properties, simply because 255 -> 255 is such an important

6 years agoRescale resampling weights so that the sum becomes one.
Steinar H. Gunderson [Sat, 25 Jan 2014 11:42:56 +0000 (12:42 +0100)]
Rescale resampling weights so that the sum becomes one.

For some reason, I had forgotten this, and it showed up because Qt
has buggy handling of pixels with alpha != 0xff. Add unit test
so it doesn't happen again.

I'm a bit concerned that rounding might cause problems so that we
should perhaps renormalize after the bilinear conversion, but we
can deal with that later if it should show up.

6 years agoRemove sandbox_effect from coverage.
Steinar H. Gunderson [Thu, 23 Jan 2014 01:20:23 +0000 (02:20 +0100)]
Remove sandbox_effect from coverage.

6 years agoAnother round of include-what-you-use.
Steinar H. Gunderson [Thu, 23 Jan 2014 01:13:27 +0000 (02:13 +0100)]
Another round of include-what-you-use.

6 years agoSet an explicit C++ tag on libtool, to ease compiling with Clang.
Steinar H. Gunderson [Thu, 23 Jan 2014 01:00:44 +0000 (02:00 +0100)]
Set an explicit C++ tag on libtool, to ease compiling with Clang.

6 years agoAdd SHELL override from autoconf, since otherwise libtool might break on systems...
Steinar H. Gunderson [Thu, 23 Jan 2014 00:50:33 +0000 (01:50 +0100)]
Add SHELL override from autoconf, since otherwise libtool might break on systems with dash.

6 years agoMove to 'using namespace std;' in all .cpp files.
Steinar H. Gunderson [Thu, 23 Jan 2014 00:35:34 +0000 (01:35 +0100)]
Move to 'using namespace std;' in all .cpp files.

There's no intrinsic value to writing std:: over and over again.
We keep it in the .h file, of course, in order not to pollute
clients' namespaces.

6 years agoTweak the exclusion rules for coverage computation a bit.
Steinar H. Gunderson [Thu, 23 Jan 2014 00:03:30 +0000 (01:03 +0100)]
Tweak the exclusion rules for coverage computation a bit.