stockfish
11 years agoRemove even more redundancy in endgame functions handling
Marco Costalba [Fri, 17 Jul 2009 12:32:27 +0000 (14:32 +0200)]
Remove even more redundancy in endgame functions handling

Push on the templatization even more to chip out some code
and take the opportunity to show some neat template trick ;-)

Ok. I would say we can stop here now....it is quickly becoming
a style exercise but we are not boost developers so give it a stop.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoRemoved an incorrect assert() statement in search.cpp, which asserted that
Tord Romstad [Fri, 17 Jul 2009 07:12:59 +0000 (09:12 +0200)]
Removed an incorrect assert() statement in search.cpp, which asserted that
a static eval cached in the transposition table would always equal the static
eval of the current position. This is in general not true, because the cached
value could be from a previous search with different evaluation parameter
settings, or from a search from the opposite side (Stockfish's evaluation
function is assymmetric by default).

11 years agoSimplify endgame functions handling
Marco Costalba [Thu, 16 Jul 2009 12:31:32 +0000 (14:31 +0200)]
Simplify endgame functions handling

We really don't need to have global endgame functions. We can
allocate them on the heap at initialization time and store the
corresponding pointer directly in the functions maps. To avoid
leaks we just need to remember to deallocate them in map d'tor.

These functions are always created in couple, one for each color,
so remove a lot of redundant hard coded info and just use the minimum
required: the type and the corresponding named string.

This greatly simplifies the code and also it is less error prone,
now is much simpler to add a new endgame specialized function: just
add the corresponding enum in endgame.h and the obvious add_xx()
call in EndgameFunctions c'tor, and of course, the most important part,
the EvaluationFunction<xxx>::apply() specialization in endgame.cpp

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoRenamed the variable 'looseOnTime' to 'loseOnTime', because I'm a pedant.
Tord Romstad [Wed, 15 Jul 2009 09:01:49 +0000 (11:01 +0200)]
Renamed the variable 'looseOnTime' to 'loseOnTime', because I'm a pedant.

No functional change.

11 years agoRemove "Last seconds noise" filtering UCI option
Marco Costalba [Mon, 13 Jul 2009 10:44:33 +0000 (11:44 +0100)]
Remove "Last seconds noise" filtering UCI option

This feature makes sense during development, but
It doesn't seem to make sense for normal users.

Also fix a possible race where the GUI adjudicates
the game a fraction of second before the engine sets
looseOnTime flag so that it will bogusly waits until
it ran out of time at the beginning of the next new game.

The fix is to always reset looseOnTime at the beginning
of a new game.

Race condition spotted by Tord.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoIntroduce SERIALIZE_MOVES_D() macro and use it for pawn moves
Marco Costalba [Tue, 14 Jul 2009 08:07:30 +0000 (10:07 +0200)]
Introduce SERIALIZE_MOVES_D() macro and use it for pawn moves

This is another moves serialization macro but this time
focused on pawn moves where the 'from' square is given as
a delta from the 'to' square.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoMicro optimize pawn moves generation
Marco Costalba [Tue, 14 Jul 2009 06:53:22 +0000 (08:53 +0200)]
Micro optimize pawn moves generation

It is very rare we have pawns on 7(2) rank, so we
can skip the promotion handling stuff in most cases.

With this patch pawn moves generation is almost 20% faster.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoIntroduce see_sign() and use it to shortcut full see()
Marco Costalba [Sat, 11 Jul 2009 08:54:30 +0000 (09:54 +0100)]
Introduce see_sign() and use it to shortcut full see()

Mostly of times we are interested only in the sign of SEE,
namely if a capture is negative or not.

If the capturing piece is smaller then the captured one we
already know SEE cannot be negative and this information
is enough most of the times. And of course it is much
faster to detect then a full SEE.

Note that in case see_sign() is negative then the returned
value is exactly the see() value, this is very important,
especially for ordering capturing moves.

With this patch the calls to the costly see() are reduced
of almost 30%.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoMove some global variables to local scope in search.cpp
Marco Costalba [Sat, 11 Jul 2009 07:02:31 +0000 (08:02 +0100)]
Move some global variables to local scope in search.cpp

Some variables were global due to some old and now removed code,
but now can be moved in local scope.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoJoona tweaks of Weights and limits
Marco Costalba [Fri, 10 Jul 2009 20:41:23 +0000 (21:41 +0100)]
Joona tweaks of Weights and limits

Verification test give unusless result

After 999 games at 1+0
Mod vs Orig +250 =503 -246 50.20% +1 ELO

So we are well below our radar level. Neverthless
there are 100.000 games on Joona QUAD that we could
take in account and that shows that this tweak perhaps
has something good in it, altough very little.

Verification tests shows should not be a regression, at
least not a big one even in the worst case, so apply the
change anyway and keep the finger crossed ;-)

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoSmall tidy up of previous patch
Marco Costalba [Fri, 10 Jul 2009 17:50:43 +0000 (18:50 +0100)]
Small tidy up of previous patch

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoStrip whitespace from beginning of string sent to set_option_value().
Tord Romstad [Fri, 10 Jul 2009 16:34:56 +0000 (18:34 +0200)]
Strip whitespace from beginning of string sent to set_option_value().

It turned out that the input sent to set_option_value() when it is called by
set_option() in uci.cpp always started with at least one whitespace. In most
cases, this is not a problem, because the majority of UCI options have numeric
values. It did, however, cause a problem for UCI options with non-numerical
values, like options of type CHECK and COMBO. In particular, changing the
value of an option of type CHECK didn't work, because the comparisons with
"true" and "false" would always return false. This means that the "Ponder"
and "UCI_Chess960" options haven't been working for a while.

11 years agoRevert last tweaks
Marco Costalba [Thu, 9 Jul 2009 12:36:08 +0000 (14:36 +0200)]
Revert last tweaks
Tests show no improvment, so revert for now.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoJoona tweaks of tempos and misc parameters
Marco Costalba [Mon, 6 Jul 2009 09:55:55 +0000 (10:55 +0100)]
Joona tweaks of tempos and misc parameters

Unfortunatly this tweak does not give good results.

After 894 games at 1+0 we have:

Mod vs Orig  +205/-236/=453 48.27%  -12 ELO !!

Perhaps we should test again, but in the mean time
we are going to revert this.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoRestore development versioning and LSN filtering
Marco Costalba [Mon, 6 Jul 2009 10:20:05 +0000 (11:20 +0100)]
Restore development versioning and LSN filtering

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoFix generation of check blocking promotion
Marco Costalba [Mon, 6 Jul 2009 08:40:50 +0000 (09:40 +0100)]
Fix generation of check blocking promotion

A promotion move is not considered a possible evasion as it could be.

Bug introduced by patch

Convert also generate_pawn_blocking_evasions() to new API (7/5/2009)

Bug spotted by Kenny Dail.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoStockfish 1.4
Marco Costalba [Sat, 4 Jul 2009 17:16:22 +0000 (18:16 +0100)]
Stockfish 1.4

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoSmall Makefile tweaks
Marco Costalba [Sat, 4 Jul 2009 20:56:04 +0000 (21:56 +0100)]
Small Makefile tweaks

Set gcc as default compiler on Linux, also compile
with symbols stripped to shrink binary file.

Original patch by Heinz van Saanen.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoFix bitcount.h compile warnings under Intel compiler
Marco Costalba [Sat, 4 Jul 2009 17:10:39 +0000 (18:10 +0100)]
Fix bitcount.h compile warnings under Intel compiler

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoCheck Intel compiler before MSVC in bitcount.h
Marco Costalba [Sat, 4 Jul 2009 17:03:49 +0000 (18:03 +0100)]
Check Intel compiler before MSVC in bitcount.h

Predefined macro __INTEL_COMPILER is defined only for Intel,
while _MSC_VER is defined for both Intel C++ and MSVC.

So rearrange ifdefs to take in account this and test __INTEL_COMPILER
first and only if not defined check _MSC_VER for MSVC.

Patch suggested by Joona.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoAdd support for saving timing file during benchmark
Marco Costalba [Sat, 4 Jul 2009 09:32:51 +0000 (10:32 +0100)]
Add support for saving timing file during benchmark

Add a new argument to bench to specify the name of the
file where timing information will be saved for each
benchmark session.

This argument is optional, if not specified file will
not be created.

Original patch by Heinz van Saanen

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoDisable POPCNT support per default
Marco Costalba [Sat, 4 Jul 2009 08:07:45 +0000 (09:07 +0100)]
Disable POPCNT support per default

This is mainly intended to allow 64 bit compiles on any
system and avoid to crash when the binary, compiled on a
box where POPCNT is not supported, is run on a Core i7
system or similar CPU.

What could happen is that when compiled in a standard 64 bit
system, because the correct headers for the POPCNT intrinsic
are not found, the compiler creates dummy bit count functions
instead, these are never called at runtime on the machine where
Stockfish has been compiled. But if we run the same binary on a
Core i7 system, because POPCNT is detected at run time, the dummy
bitcount functions will be called giving false results that will
crash the application.

Note that would be possible to fallback on software bit count in
these cases, but this is even more subtle because POPCNT path is not
optimized so that we have an application working but at sub-optimal
speed, so better to crash, at least user is loudly warned that there
is something wrong.

If, instead, Stockfish is compiled on a Core i7 system with POPCNT
enabled, then if the PGO compile has been done properly, the same binary
will run at optimal speed _both_ on the Core i7 machine and on any other
64 bit standard machine. This is the ideal mode for binary distribution.

Finally this patch disables bsfq support under Windows, because it seems
inline assembly is not supported both by MSVC and by Intel Windows version.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoDo not compile POPCNT if NO_POPCNT is defined
Marco Costalba [Fri, 3 Jul 2009 12:18:59 +0000 (13:18 +0100)]
Do not compile POPCNT if NO_POPCNT is defined

Also rename DISABLE_POPCNT_SUPPORT in NO_POPCNT and simplify a bit
the macro logic.

Always define a __popcnt64()or _mm_popcnt_u64() template, if the proper
function with the same name is defined in the intrinsics header, then it
will be choosen as first otherwise we fall back on the dummy template
that is never called at runtime anyway because cpu_has_popcnt() returns
false.

This fixes the compile error reported by Jim.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoMicroptimize pawns info access
Marco Costalba [Fri, 3 Jul 2009 10:28:11 +0000 (12:28 +0200)]
Microptimize pawns info access

Avoid indirect calling of piece_of_color_and_type(c, PAWN) and its
alias pawns(c) in the pawn evaluation loop, but use the pawns
bitboards accessed only once before entering the loop.

Also explicitly mark functions as static to better self-document.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoRestore correct 64 bit version of pop_1st_bit()
Marco Costalba [Fri, 3 Jul 2009 07:40:41 +0000 (08:40 +0100)]
Restore correct 64 bit version of pop_1st_bit()

Was erroneusly changed with the 32bit in recent
patch "Retire USE_COMPACT_ROOK_ATTACKS...".

Also another clean up of define magics. Move compiler
specific definitions in types.h and remove redundant cruft.

Now this macro ugly mess seems more reasonable.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoUse bsfq asm instruction to count bits
Marco Costalba [Fri, 3 Jul 2009 07:28:13 +0000 (08:28 +0100)]
Use bsfq asm instruction to count bits

On 64 bit systems we can use bsfq instruction to count
set bits in a bitboard.

This is a patch for GCC and Intel compilers to take advantage
of that and get a 2% speed up.

Original patch from Heinz van Saanen, adapted to current tree
by me.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoRetire USE_COMPACT_ROOK_ATTACKS and USE_FOLDED_BITSCAN defines
Marco Costalba [Thu, 2 Jul 2009 14:49:41 +0000 (16:49 +0200)]
Retire USE_COMPACT_ROOK_ATTACKS and USE_FOLDED_BITSCAN defines

This greatly simplifies bitboard.cpp that now has only two setups,
respectively for 32 and 64 bits CPU according to IS_64BIT define
that is automatically set but can be tweaked manually in
bitboard.h

No functional change both in 32 and in 64 bits.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoRevert per-thread history tables
Marco Costalba [Thu, 2 Jul 2009 00:54:17 +0000 (01:54 +0100)]
Revert per-thread history tables

Testing on Joona QUAD failed to give any
advantage. Actually we had a little loss:

Mod - Orig: 342.0 - 374.0

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoJoona tweaks of piece values
Marco Costalba [Sun, 28 Jun 2009 23:50:36 +0000 (01:50 +0200)]
Joona tweaks of piece values

This is the backport of tuned piece values.

We needed to change also the psqt tables so that their
values, that are relative to piece values, remain the same.

Amost no change after 999 games:

Mod vs Orig 594-495 + 2 ELO points so well within error bar

It was expected somehow given the very little change of the
parameters values.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoExplicitly use delta psqt values when possible
Marco Costalba [Sun, 28 Jun 2009 03:56:58 +0000 (05:56 +0200)]
Explicitly use delta psqt values when possible

Instead of add and subtract pqst values corrisponding to
the move starting and destination squares, do it in one
go with the helper function pst_delta<>()

This simplifies the code and also better documents that what
we need is a delta value, not an absolute one.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoJoona tweaks of pawns parameters
Marco Costalba [Mon, 22 Jun 2009 06:16:43 +0000 (08:16 +0200)]
Joona tweaks of pawns parameters

Test result after 999 games at 1+0

Mod vs Orig +278 =493 -228 52,50% +17 ELO

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoFix compile errors in debug mode
Marco Costalba [Sat, 20 Jun 2009 18:18:00 +0000 (19:18 +0100)]
Fix compile errors in debug mode

Fall out of move_promotion() rename

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoUse POPCNT in evaluate_space() when available
Marco Costalba [Sat, 20 Jun 2009 12:21:15 +0000 (14:21 +0200)]
Use POPCNT in evaluate_space() when available

This was forgotten by the POCNT patches.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoFix a couple of warnings under Intel compiler
Marco Costalba [Sat, 20 Jun 2009 11:56:31 +0000 (13:56 +0200)]
Fix a couple of warnings under Intel compiler

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoMicro optimize and rename move_promotion()
Marco Costalba [Sat, 20 Jun 2009 07:31:39 +0000 (08:31 +0100)]
Micro optimize and rename move_promotion()

Rename to move_is_promotion() to be more clear, also add
a new function move_promotion_piece() to get the
promotion piece type in the few places where is needed.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoOnly on Windows do wait for input at the end of benchmark
Marco Costalba [Sat, 20 Jun 2009 06:58:05 +0000 (07:58 +0100)]
Only on Windows do wait for input at the end of benchmark

Under MS Visual C++ debug window always unconditionally closes
when program exits, this is bad because we want to read results before.

So limit this kludge on Windows only.

Original patch by Heinz van Saanen.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoSkip castle rights update when not needed
Marco Costalba [Thu, 18 Jun 2009 13:22:39 +0000 (15:22 +0200)]
Skip castle rights update when not needed

Micro optimization in do_move(), a quick check
avoid us to update castle rights in almost 90%
of cases.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoDisable use of aspiration window in known win positions
Joona Kiiski [Wed, 17 Jun 2009 10:16:51 +0000 (13:16 +0300)]
Disable use of aspiration window in known win positions

When we are hunting for mate, transposition table is filled in
with mate scores. Current implemenatation of aspiration search
can't cope with this very well.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoBugfix: KRK was not classified as KNOWN_WIN
Joona Kiiski [Wed, 17 Jun 2009 08:07:16 +0000 (11:07 +0300)]
Bugfix: KRK was not classified as KNOWN_WIN

Problem is that npMaterial is compared to _endgame_ value
of rook, although npMaterial is always (also in endgame!)
calculated using _middlegame_ values.

Bug was hidden as long as Rook middlegame
and endgame values were same.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoGive proper credit to Joona
Marco Costalba [Wed, 17 Jun 2009 06:59:09 +0000 (08:59 +0200)]
Give proper credit to Joona

Stockfish would not be as where is now without his
contributions.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoJoona tweaks of mobility and outposts bonus
Marco Costalba [Tue, 16 Jun 2009 13:06:26 +0000 (15:06 +0200)]
Joona tweaks of mobility and outposts bonus

These are the tuned values of mobility and outposts
after 100.000 games on Joona QUAD.

After 999 games at 1+0
Mod vs Orig +248 =537 -214 51.70% +12 ELO

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoFix king value in SEE
Marco Costalba [Tue, 16 Jun 2009 18:20:53 +0000 (19:20 +0100)]
Fix king value in SEE

When SEE piece values changed in aaad48464b
of 9/12/2008 we forgot to update the value assigned in
case of captured king.

In that patch we changed the SEE piece values but without
proper testing. Probably it is a good idea to make some
tests with the old Glaurung values.

Bug spotted by Joona.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoReduce SMP contention on TT
Marco Costalba [Sat, 13 Jun 2009 10:13:09 +0000 (11:13 +0100)]
Reduce SMP contention on TT

Move TT object away from heavy write accessed NodesSincePoll
and also, inside TT isolate the heavy accessed writes variable.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoBetter clarify why recent generate_pawn_checks() works
Marco Costalba [Fri, 12 Jun 2009 10:05:48 +0000 (12:05 +0200)]
Better clarify why recent generate_pawn_checks() works

We can have false positives, but these are filtered out
anyhow by following conditions so they are harmless.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoCode style triviality in search.cpp
Marco Costalba [Thu, 11 Jun 2009 13:57:42 +0000 (15:57 +0200)]
Code style triviality in search.cpp

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoRemove global variables from search.h
Marco Costalba [Thu, 11 Jun 2009 13:11:08 +0000 (15:11 +0200)]
Remove global variables from search.h

Globals are not really needed, so redefine as locals.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoMovePicker doesn't need to know if called from a pv node
Marco Costalba [Thu, 11 Jun 2009 09:04:05 +0000 (11:04 +0200)]
MovePicker doesn't need to know if called from a pv node

This was needed by an old optimization in sorting of
non-captures that is now obsoleted by new std::sort()
approach.

Remove also the unused depth member data. Interestingly
this has always been unused since the Glaurung days.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoJoona tweaks of piece-square tables
Marco Costalba [Tue, 9 Jun 2009 10:21:35 +0000 (11:21 +0100)]
Joona tweaks of piece-square tables

These are the tuned psqt values after 100.000 games
on Joona QUAD. Results seem very good.

On PC 1 after 999 games
Mod vs Orig  +261 =511 -227 51.70 %  +12 ELO

On PC 2 after 913 games
Mod vs Orig  +254 =448 -211 52.35 %  +16 ELO

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoMove initialization of PawnInfo in its c'tor
Marco Costalba [Mon, 8 Jun 2009 11:52:52 +0000 (12:52 +0100)]
Move initialization of PawnInfo in its c'tor

Where it belongs.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoMove initialization of MaterialInfo in its c'tor
Marco Costalba [Mon, 8 Jun 2009 10:27:50 +0000 (11:27 +0100)]
Move initialization of MaterialInfo in its c'tor

Where it belongs.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoMicro optimize pretty_pv
Marco Costalba [Mon, 8 Jun 2009 09:52:03 +0000 (10:52 +0100)]
Micro optimize pretty_pv

Creating an History object requires clearing the History tables,
although fast is an useless job in san.cpp where History is used
just as a dummy argument for MovePicker c'tor.

So use a file scoped constant instead of creating a new History()
object each time MovePicker c'tor is called as in move_ambiguity()

This optimizes pretty_pv() through the following calling chain:
pretty_pv() -> line_to_san() -> move_to_san() -> move_ambiguity()

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoGive credit to Joona for optimized parameters
Marco Costalba [Fri, 5 Jun 2009 12:27:37 +0000 (14:27 +0200)]
Give credit to Joona for optimized parameters

This also allow us to better track what is already
optimized and what still needs optimization.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoUse a specialized function for king evaluation
Marco Costalba [Fri, 5 Jun 2009 10:58:03 +0000 (12:58 +0200)]
Use a specialized function for king evaluation

King evaluation is special in any case and as an added
benefit we can use the HasPopCnt optimization also for king.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoSplit evaluate_outposts from evaluate_common
Marco Costalba [Sat, 9 May 2009 21:21:26 +0000 (22:21 +0100)]
Split evaluate_outposts from evaluate_common

This is an old patch, was part of a series, but is
good also alone as a cleanup.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoDocument variables with heavy SMP read access
Marco Costalba [Wed, 3 Jun 2009 08:19:29 +0000 (10:19 +0200)]
Document variables with heavy SMP read access

Also move NodesSincePoll away from the same cache line
of other heavy read accessed only variables.

Fortunatly we don't have anymore write access contention,
but still read access contention in some cases.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoRetire UseQSearchFutilityPruning and UseFutilityPruning
Marco Costalba [Wed, 3 Jun 2009 08:00:05 +0000 (10:00 +0200)]
Retire UseQSearchFutilityPruning and UseFutilityPruning

They are always true anyway and are heavy used file scope
variables where there could be SMP contention. Although read only.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoUse one History table per thread
Marco Costalba [Tue, 2 Jun 2009 09:20:41 +0000 (10:20 +0100)]
Use one History table per thread

This reduces contention and reduce history trashing
effect especially at high search depths.

No functional change for single CPU case.

After 999 games at 1+0 on Dual Core Intel we have

Mod vs Orig  +233 =526 -240  -2 ELO

We need to test at longer time controls and possibly with
a QUAD where we could foreseen an improvment.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoConvert History table H in a local variable
Marco Costalba [Tue, 2 Jun 2009 08:57:15 +0000 (09:57 +0100)]
Convert History table H in a local variable

This is a first step for future patches and in
any case seems a nice thing to do.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoAvoid using EmptySearchStack global
Marco Costalba [Tue, 2 Jun 2009 08:35:49 +0000 (09:35 +0100)]
Avoid using EmptySearchStack global

This reduces contention in SMP case and also
cleanups the code a bit.

No functional change

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoDetach the state when copying a position
Marco Costalba [Fri, 29 May 2009 15:23:21 +0000 (17:23 +0200)]
Detach the state when copying a position

In Position we store a pointer to a StateInfo record
kept outside of the Position object.

When copying a position we copy also that pointer so
after the copy we have two Position objects pointing
to the same StateInfo record. This can be dangerous
so fix by copying also the StateInfo record inside
the new Position object and let the new st pointer
point to it. This completely detach the copied
Position from the original one.

Also rename setStartState() as saveState() and clean up
the API to state more clearly what the function does.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoOrder bad captures by SEE value
Marco Costalba [Thu, 28 May 2009 12:58:35 +0000 (14:58 +0200)]
Order bad captures by SEE value

We have already calculated it, so just sorting the
moves adds a very little overhead.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoPassed pawns evaluation tweak
Marco Costalba [Mon, 25 May 2009 14:48:47 +0000 (15:48 +0100)]
Passed pawns evaluation tweak

Do not penalize if in our adavncing pawn's path there are
non-pawns enemy pieces. Especially if they can be attacked
by us.

Patch is mine, but original idea and also fixing of a first, wrong,
version of the patch is from Eelco de Groot.

Tests with Joona framework seems to confirm patch is good

Results for patch 'disabled'   based on 5776 games: Win percentage:
41.309  (+- 0.526)  [+- 1.053]
Results for patch 'enabled'  based on 6400 games: Win percentage:
42.422  (+- 0.500)  [+- 1.000]

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoMerge hardware POPCNT detection and use
Marco Costalba [Mon, 25 May 2009 06:52:59 +0000 (07:52 +0100)]
Merge hardware POPCNT detection and use

Tests on Joona luxury iCore7 QUAD show that speed increase
against standrd 64bit routine is between 3% and 4%.

So it seems a good thing to have. Also the user feedback at
startup regarding the compile and the hardware detection can
be an useful debug tool.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoSplit killer moves from non-captures
Marco Costalba [Mon, 25 May 2009 06:49:50 +0000 (07:49 +0100)]
Split killer moves from non-captures

In MovePicker consider killer moves as a separate
phase from non-capture picking.

Note that this change guarantees that killer1 is always
tried before killer2. Until now, because scoring difference
of the two moves was just 1 point, if psqt tables of killer1
gave a lower value then killer2, the latter was tried as first.

After 999 games at 1+0 we have
Mod vs Orig: +245 =527 -227 +6 ELO

Not a lot but patch is anyhow something worth to have.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoRevert _BitScanForward64 support
Marco Costalba [Mon, 25 May 2009 06:28:55 +0000 (07:28 +0100)]
Revert _BitScanForward64 support

It shows almost no improvment and adds a good
bunch of complexity.

So remove for now. No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoAdd a bit more pop_1st_bit<HasBSF> conversions
Marco Costalba [Sun, 24 May 2009 09:25:59 +0000 (10:25 +0100)]
Add a bit more pop_1st_bit<HasBSF> conversions

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoUse compiler name lookup to simplify code
Marco Costalba [Sun, 24 May 2009 09:15:23 +0000 (10:15 +0100)]
Use compiler name lookup to simplify code

We don't need different names between a function and a
template. Compiler will know when use one or the other.

This let use restore original count_1s_xx() names instead of
sw_count_1s_xxx so to simplify a bit the code.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoEnable _BitScanForward64 in move generation
Marco Costalba [Sun, 24 May 2009 09:07:03 +0000 (10:07 +0100)]
Enable _BitScanForward64 in move generation

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoEnable _BitScanForward64 at runtime
Marco Costalba [Sun, 24 May 2009 08:46:43 +0000 (09:46 +0100)]
Enable _BitScanForward64 at runtime

Only add infrastructure, still disabled.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoPrint info about use of 64bit functions and hardware POPCNT
Marco Costalba [Sat, 23 May 2009 10:42:43 +0000 (11:42 +0100)]
Print info about use of 64bit functions and hardware POPCNT

With this patch at the applications startup a line is printed
with info about use of optimized 64 bit routines and hardware
POPCNT.

Also allow the possibility to disable POPCNT support during
PGO compiles to exercise the fallback software only path.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoFix compile errors under MSVC
Marco Costalba [Thu, 21 May 2009 16:08:34 +0000 (17:08 +0100)]
Fix compile errors under MSVC

Fallback from previous patches.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoForgot two conversion to new POPCNT interface
Marco Costalba [Thu, 21 May 2009 14:50:19 +0000 (16:50 +0200)]
Forgot two conversion to new POPCNT interface

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoAdd temporary debug info on POPCNT support
Marco Costalba [Thu, 21 May 2009 14:42:07 +0000 (16:42 +0200)]
Add temporary debug info on POPCNT support

To be removed before to release.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoEnable POPCNT at runtime
Marco Costalba [Thu, 21 May 2009 14:41:31 +0000 (16:41 +0200)]
Enable POPCNT at runtime

Runtime detect POPCNT instruction support and
use it.

Also if POPCNT is not supported we don't add _any_ overhead so
that we don't lose any speed in standard case.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoIntroduce bitcount.h
Marco Costalba [Thu, 21 May 2009 13:29:28 +0000 (15:29 +0200)]
Introduce bitcount.h

It will be used for POPCNT intrinsics.

For now no bianry and functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoUnify piece_attacks<> for KNIGHT and KING
Marco Costalba [Thu, 21 May 2009 10:15:52 +0000 (12:15 +0200)]
Unify piece_attacks<> for KNIGHT and KING

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoUse do_move_bb() also for en passant moves
Marco Costalba [Thu, 21 May 2009 09:28:51 +0000 (11:28 +0200)]
Use do_move_bb() also for en passant moves

Unfortunatly, due to Chess960 compatibility we cannot
extend also to castling where the destinations squares
are not guaranteed to be empty.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoIntroduce do_move_bb() to update bitboards after a move
Marco Costalba [Thu, 21 May 2009 08:55:23 +0000 (10:55 +0200)]
Introduce do_move_bb() to update bitboards after a move

Avoid a clear_bit() + set_bit() sequence but update bitboards
with only one xor instructions.

This is faster and simplifies the code.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoBackup some mor einfo in do_null_move()
Marco Costalba [Thu, 21 May 2009 07:54:48 +0000 (09:54 +0200)]
Backup some mor einfo in do_null_move()

Faster undo_null_move()

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoMove npMaterial[2] to StateInfo in Position
Marco Costalba [Thu, 21 May 2009 07:47:03 +0000 (09:47 +0200)]
Move npMaterial[2] to StateInfo in Position

So to have a bit faster undo_move() and also
a code semplification.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoRetire lastMove from Position class
Marco Costalba [Wed, 20 May 2009 13:12:45 +0000 (15:12 +0200)]
Retire lastMove from Position class

Is not used in any way so remove.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoSmall code style in headers
Marco Costalba [Wed, 20 May 2009 13:11:41 +0000 (15:11 +0200)]
Small code style in headers

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoDirectly relate HistoryMax to OnePly
Marco Costalba [Wed, 20 May 2009 12:40:50 +0000 (14:40 +0200)]
Directly relate HistoryMax to OnePly

This obsoletes some remainding comments.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoSmall code style massage in uci.cpp
Marco Costalba [Wed, 20 May 2009 10:40:07 +0000 (12:40 +0200)]
Small code style massage in uci.cpp

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoSpace inflate and cleanup direction.cpp
Marco Costalba [Wed, 20 May 2009 10:02:39 +0000 (12:02 +0200)]
Space inflate and cleanup direction.cpp

Hopefully it is now more clear what's happening here.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoReduce history 4 times instead of 2 when reach the maximum
Marco Costalba [Mon, 18 May 2009 07:51:46 +0000 (09:51 +0200)]
Reduce history 4 times instead of 2 when reach the maximum

This gives more weight to newer entries.

After 999 games at 1'+ 0" we have:

Mod vs Orig +233/-208/=558 51.25% +9 ELO

Confirmed by another session of 437 games:

Mod vs Orig +109/-92/=236 51.95% +14 ELO

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoRetire count_1s_8bit()
Marco Costalba [Tue, 19 May 2009 14:49:54 +0000 (15:49 +0100)]
Retire count_1s_8bit()

Use the plain array lookup in the only place where it
is used. This remove an unecessary indirection and better
clarifies what code does.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoSmall code style triviality in evaluation
Marco Costalba [Tue, 19 May 2009 14:41:45 +0000 (15:41 +0100)]
Small code style triviality in evaluation

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoRemove hardcode default values of UCI variables from evaluation
Marco Costalba [Tue, 19 May 2009 14:35:12 +0000 (15:35 +0100)]
Remove hardcode default values of UCI variables from evaluation

This is the same change we have already done in search.cpp,
this time for evaluation.cpp

If a variable will be populated reading an UCI option
then do not hard code its default values.

This avoids misleadings when reading the sources.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoCache king shelter info in pawns structure
Marco Costalba [Sat, 16 May 2009 14:15:05 +0000 (16:15 +0200)]
Cache king shelter info in pawns structure

It does not change often and is not so fast
to calculate.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoMove beta counter variables to the per-thread data
Marco Costalba [Sat, 16 May 2009 11:22:40 +0000 (12:22 +0100)]
Move beta counter variables to the per-thread data

This should reduce concurrent accessing in SMP case.

Suggestion by Tord Romstad.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoBetter document how history works
Marco Costalba [Fri, 15 May 2009 14:42:30 +0000 (16:42 +0200)]
Better document how history works

Both with added comment and changing the API to
reflect that only destination square and moved piece
is important for history.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoFix broken multi-pv with aspiration window search
Marco Costalba [Fri, 15 May 2009 07:39:36 +0000 (09:39 +0200)]
Fix broken multi-pv with aspiration window search

Aspiration window search must be disabled for
multi-pv case.

We missed one point where aspiration window should
be disabled in this case.

Patch from Joona, with a little added edit by me.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoFix a warning un using anonymous structs
Marco Costalba [Tue, 12 May 2009 10:10:40 +0000 (12:10 +0200)]
Fix a warning un using anonymous structs

No functional and no binary change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoUse string instead of std::string
Marco Costalba [Sun, 10 May 2009 16:58:53 +0000 (17:58 +0100)]
Use string instead of std::string

And others small code style touches.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoUse 64 bits for debug counters
Marco Costalba [Sun, 10 May 2009 11:21:45 +0000 (13:21 +0200)]
Use 64 bits for debug counters

Has happened 32 bits were not enough for
some test.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoFix some Intel compilers warnings
Marco Costalba [Sat, 9 May 2009 10:01:00 +0000 (12:01 +0200)]
Fix some Intel compilers warnings

Also a compile fix due to Makefile missing new
application.cpp file.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoMicro optimize generate_pawn_checks()
Marco Costalba [Fri, 8 May 2009 08:53:45 +0000 (10:53 +0200)]
Micro optimize generate_pawn_checks()

Use a better condition to find candidate direct check pawns.
In particular consider only pawns in the front ranks of the
enemy king, this greatly reduces pawns candidates bitboard
that now is empty more then 90% of the time so that we
can early skip further tests.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoConvert also generate_pawn_blocking_evasions() to new API
Marco Costalba [Thu, 7 May 2009 15:08:55 +0000 (17:08 +0200)]
Convert also generate_pawn_blocking_evasions() to new API

New compact parameter passing API.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
11 years agoBetter dscovery check condition in generate_pawn_checks()
Marco Costalba [Thu, 7 May 2009 15:01:52 +0000 (17:01 +0200)]
Better dscovery check condition in generate_pawn_checks()

Be more strict, is not enough dc bitboard is not empty, but
needs to inclde also at least one pawn.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>